[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

rshen91 · 2022-08-22T21:35:52Z

Summary

This PR migrates the avatar work into the shared UX realm.

In Future PRs:

Add a deprecation message to the original package [Shared UX]Add deprecation comments #141159

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…-fix'

…atars

…-fix'

…atars

…-fix'

…atars

…-fix'

…atars

majagrubic

Did not finish reviewing, just leaving some comments for now

packages/shared-ux/avatar/user_profile/impl/user_profile.ts

majagrubic

Tested in Chrome on Mac OSX in storybook, works nicely. Left a few comments, but mostly nits.

majagrubic · 2022-09-14T10:33:37Z

packages/shared-ux/avatar/user_profile/impl/user_profiles_selectable.tsx

+      searchProps={{
+        placeholder:
+          searchPlaceholder ??
+          i18n.translate(


should this be a constant?

I dig it - 702fb2e for updates

majagrubic · 2022-09-14T10:36:53Z

packages/shared-ux/avatar/user_profile/impl/user_profiles_selectable.tsx

+                      />
+                    )}
+                  </EuiButtonEmpty>
+                ) : undefined}


nit: should be null

Nice good catch 702fb2e

…uild_manifest'

…atars

…-fix'

kibana-ci · 2022-09-19T19:18:31Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/shared-ux-avatar-user-profile-components`	-	3	+3

Unknown metric groups

API count

id	before	after	diff
`@kbn/shared-ux-avatar-user-profile-components`	-	40	+40

ESLint disabled line counts

id	before	after	diff
`@kbn/shared-ux-avatar-user-profile-components`	-	2	+2

Total ESLint disabled count

id	before	after	diff
`@kbn/shared-ux-avatar-user-profile-components`	-	2	+2

History

💚 Build #70614 succeeded 85292e5
💚 Build #69824 succeeded f08bab4
💚 Build #69184 succeeded 1e87680
💚 Build #69162 succeeded 3224aaa
💔 Build #69139 failed bf45911
💔 Build #69100 failed 5b80a0f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

rshen91 added 6 commits August 22, 2022 15:34

initial commit

1287f76

update

f584010

fix namespace issue

051c620

tsconfig

dac121e

Merge remote-tracking branch 'upstream/main' into migrate-avatars

fa0b752

fix build

e1ce125

rshen91 self-assigned this Aug 23, 2022

rshen91 mentioned this pull request Aug 25, 2022

[Meta] Transition Components to SharedUX From React Plugin #122961

Open

15 tasks

rshen91 and others added 17 commits August 26, 2022 11:45

Merge branch 'main' into migrate-avatars

d9dd16f

add to story

d8dc044

Merge remote-tracking branch 'upstream/main' into migrate-avatars

3caeefe

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

7227b69

…-fix'

story

68c0521

Merge remote-tracking branch 'origin/migrate-avatars' into migrate-av…

d4dd357

…atars

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

bdb1875

…-fix'

remove srcdirectory

706bba1

Merge remote-tracking branch 'origin/migrate-avatars' into migrate-av…

66027b7

…atars

Merge remote-tracking branch 'upstream/main' into migrate-avatars

3c2e0b0

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

5e7bd52

…-fix'

update

808a84c

Merge remote-tracking branch 'upstream/main' into migrate-avatars

a5e2318

update

5b80a0f

flesh out readme

bf45911

tsconfig

3224aaa

Merge branch 'main' into migrate-avatars

1e87680

rshen91 added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) release_note:skip Skip the PR/issue when compiling release notes labels Sep 6, 2022

rshen91 added 3 commits September 6, 2022 11:35

fix story

d27abd2

Merge remote-tracking branch 'origin/migrate-avatars' into migrate-av…

b2cc260

…atars

Merge branch 'main' into migrate-avatars

2e99727

rshen91 marked this pull request as ready for review September 6, 2022 17:38

rshen91 requested a review from a team September 6, 2022 17:38

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

f08bab4

…-fix'

rshen91 requested a review from majagrubic September 8, 2022 13:13

rshen91 added 2 commits September 8, 2022 12:58

Merge remote-tracking branch 'upstream/main' into migrate-avatars

8fd357e

Merge remote-tracking branch 'origin/migrate-avatars' into migrate-av…

85292e5

…atars

majagrubic reviewed Sep 14, 2022

View reviewed changes

packages/shared-ux/avatar/user_profile/impl/user_profile.ts Outdated Show resolved Hide resolved

packages/shared-ux/avatar/user_profile/impl/user_profile.ts Outdated Show resolved Hide resolved

packages/shared-ux/avatar/user_profile/impl/user_profile.ts Outdated Show resolved Hide resolved

majagrubic approved these changes Sep 14, 2022

View reviewed changes

rshen91 and others added 7 commits September 19, 2022 10:14

update

45aa4b9

Merge remote-tracking branch 'upstream/main' into migrate-avatars

0e3c43e

[CI] Auto-commit changed files from 'node scripts/generate packages_b…

1e5076c

…uild_manifest'

update to camelcase

b448ed9

Merge remote-tracking branch 'origin/migrate-avatars' into migrate-av…

d7b5a90

…atars

update code review

702fb2e

Merge branch 'main' into migrate-avatars

90b1442

rshen91 enabled auto-merge (squash) September 19, 2022 17:33

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

91bfc6a

…-fix'

rshen91 merged commit 7734761 into elastic:main Sep 19, 2022

kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Sep 19, 2022

rshen91 deleted the migrate-avatars branch September 20, 2022 17:47

rshen91 mentioned this pull request Sep 21, 2022

[Shared UX]Add deprecation comments #141159

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

rshen91 commented Aug 22, 2022 •

edited

Loading

majagrubic left a comment

majagrubic left a comment

majagrubic Sep 14, 2022

rshen91 Sep 19, 2022

majagrubic Sep 14, 2022

rshen91 Sep 19, 2022

kibana-ci commented Sep 19, 2022

API count

ESLint disabled line counts

Total ESLint disabled count

[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

Conversation

rshen91 commented Aug 22, 2022 • edited Loading

Summary

Checklist

For maintainers

majagrubic left a comment

Choose a reason for hiding this comment

majagrubic left a comment

Choose a reason for hiding this comment

majagrubic Sep 14, 2022

Choose a reason for hiding this comment

rshen91 Sep 19, 2022

Choose a reason for hiding this comment

majagrubic Sep 14, 2022

Choose a reason for hiding this comment

rshen91 Sep 19, 2022

Choose a reason for hiding this comment

kibana-ci commented Sep 19, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

API count

ESLint disabled line counts

Total ESLint disabled count

History

rshen91 commented Aug 22, 2022 •

edited

Loading